Bug 119247 - [WIN] Remove dependency on CoreFoundation from DownloadBundle
Summary: [WIN] Remove dependency on CoreFoundation from DownloadBundle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-30 05:21 PDT by Patrick R. Gansterer
Modified: 2013-07-30 11:59 PDT (History)
3 users (show)

See Also:

Attachments
Patch (8.83 KB, patch)
2013-07-30 05:28 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Patch (8.83 KB, patch)
2013-07-30 05:35 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2013-07-30 05:21:18 PDT 
[WIN] Remove dependecy on CoreFoundation from DownloadBundle
Comment 1 Patrick R. Gansterer 2013-07-30 05:28:09 PDT 
Created attachment 207723 [details]
Patch
Comment 2 WebKit Commit Bot 2013-07-30 05:30:12 PDT 
Attachment 207723 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/network/cf/DownloadBundle.h', u'Source/WebCore/platform/network/curl/DownloadBundle.h', u'Source/WebCore/platform/network/win/DownloadBundleWin.cpp', u'Source/WebKit/win/WebDownloadCFNet.cpp']" exit_code: 1
Source/WebKit/win/WebDownloadCFNet.cpp:174:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Patrick R. Gansterer 2013-07-30 05:35:59 PDT 
Created attachment 207726 [details]
Patch
Comment 4 WebKit Commit Bot 2013-07-30 11:59:55 PDT 
Comment on attachment 207726 [details]
Patch

Clearing flags on attachment: 207726

Committed r153485: <http://trac.webkit.org/changeset/153485>
Comment 5 WebKit Commit Bot 2013-07-30 11:59:57 PDT 
All reviewed patches have been landed.  Closing bug.