Bug 119210

Summary: [WIN] Add implementation for WebCore::readFromFile()
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: PlatformAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch bfulgham: review+

Patrick R. Gansterer
Reported 2013-07-29 02:38:26 PDT
[WIN] Add implementation for WebCore::readFromFile()
Attachments
Patch (1.34 KB, patch)
2013-07-29 02:42 PDT, Patrick R. Gansterer 		bfulgham: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2013-07-29 02:42:43 PDT
Created attachment 207627 [details] Patch
Brent Fulgham
Comment 2 2013-07-30 09:37:08 PDT
Comment on attachment 207627 [details] Patch readFromFile is not currently used on the Windows build. Is there a corresponding change that causes this code to be needed?
Patrick R. Gansterer
Comment 3 2013-07-30 09:38:57 PDT
(In reply to comment #2) > (From update of attachment 207627 [details]) > readFromFile is not currently used on the Windows build. Is there a corresponding change that causes this code to be needed? Not yet, but I like to port some code, which will use it.
Brent Fulgham
Comment 4 2013-07-30 10:16:25 PDT
Comment on attachment 207627 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207627&action=review r=me. Please consider adding the global namespace prefix to the ReadFile method call. > Source/WebCore/platform/win/FileSystemWin.cpp:393 > + bool success = ReadFile(handle, data, length, &bytesRead, 0); We prefer to say "::ReadFile" for these global WinAPI calls.
Patrick R. Gansterer
Comment 5 2013-09-23 16:25:38 PDT
Committed r156306: <http://trac.webkit.org/changeset/156306>
Note You need to log in before you can comment on or make changes to this bug.