Bug 119208

Summary: [GTK] Use WTF_PLATFORM_X11 instread of GDK_WINDOWING_X11
Product: WebKit Reporter: ChangSeok Oh <kevin.cs.oh>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: cgarcia, changseok, commit-queue, d-r, eric.carlson, glenn, gustavo, jer.noble, menard, mrobinson, pnormand, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch gustavo: review-, gustavo: commit-queue-

ChangSeok Oh
Reported 2013-07-29 01:06:32 PDT
Gtk can have GDK_WINDOWING_X11 and GDK_WINDOWING_WAYLAND at the same time. So I think it would be better to use WTF_PLATFORM_X11 flag than to use GDK_WINDOWING_X11 for future wayland support.
Attachments
Patch (10.91 KB, patch)
2013-07-29 01:24 PDT, ChangSeok Oh 		gustavo: review-
gustavo: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
ChangSeok Oh
Comment 1 2013-07-29 01:24:56 PDT
Created attachment 207626 [details] Patch
WebKit Commit Bot
Comment 2 2013-07-29 01:27:29 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Zan Dobersek
Comment 3 2013-07-29 03:14:23 PDT
FWIW, I believe the future plan is to also have concurrent support for both X11 and Wayland protocols in the same build, like the GTK+ toolkit itself.
Gustavo Noronha (kov)
Comment 4 2013-07-29 06:43:33 PDT
Comment on attachment 207626 [details] Patch Yeah, since the plan is to be able to enable both and select at runtime, I think this change is probably not worth it. We would need to decide how we want to decide what to enabled, for that.
Note You need to log in before you can comment on or make changes to this bug.