Bug 11919

Summary: Allow setting CSS values to null.
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: CSSAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: mrowe
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
proposed patch
none
proposed patch darin: review+

Alexey Proskuryakov
Reported 2006-12-21 11:30:46 PST
So, I'm proposing a patch that makes assigning null values to CSS properties work again. This doesn't match WinIE, but matches Firefox.
Attachments
proposed patch (5.10 KB, patch)
2006-12-21 11:38 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
proposed patch (5.06 KB, patch)
2006-12-21 12:17 PST, Alexey Proskuryakov 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2006-12-21 11:38:01 PST
Created attachment 11954 [details] proposed patch args[1]->isNull() ? String() : String(args[1]->toString(exec)) doesn't look particularly good to me - do we have a better idiom?
Darin Adler
Comment 2 2006-12-21 11:41:43 PST
(In reply to comment #1) > args[1]->isNull() ? String() : String(args[1]->toString(exec)) doesn't look > particularly good to me - do we have a better idiom? We do -- valueToStringWithNullCheck is the name.
Alexey Proskuryakov
Comment 3 2006-12-21 12:17:30 PST
Created attachment 11955 [details] proposed patch Uses valueToStringWithNullCheck(). Thank you!
Darin Adler
Comment 4 2006-12-21 12:25:34 PST
Comment on attachment 11955 [details] proposed patch r=me
Alexey Proskuryakov
Comment 5 2006-12-21 12:31:35 PST
Committed revision 18377.
Note You need to log in before you can comment on or make changes to this bug.