Bug 119163

Summary: EGL surfaces code has EFL-specific code
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: cmarcelo, commit-queue, gyuyoung.kim, kalyan.kondapally, kondapallykalyan, luiz, noam, rakuco, sergio, zeno
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2013-07-26 14:38:27 PDT
Source/WebCore/platform/graphics/surfaces/egl/EGLSurface.h #includes GLTransportSurface.h, which is in Source/WebCore/platform/graphics/surfaces/efl. The efl code should not be compiled on non-efl platforms.
Attachments
Patch (1.60 KB, patch)
2013-07-26 14:43 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (25.31 KB, patch)
2013-07-29 13:10 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-07-26 14:43:35 PDT
Created attachment 207556 [details] Patch
Kalyan
Comment 2 2013-07-26 15:41:10 PDT
we can try to reuse GLTransportSurface class and GraphicsSurfaceCommon classes and move them outside efl folder. Couple of changes needed here: 1)GLTransportSurface has a dependency on TextureMapperShaderProgram to render textures to surface. I don't know if that is going to be an issue for you (otherwise we would need to implement a shader here). 2)GraphicsSurfaceCommon currently has support for CoordinateGraphics. We should include function platformPaintToTextureMapper only when Co-ordinatedGraphics is supported.
Alex Christensen
Comment 3 2013-07-26 15:45:18 PDT
Comment on attachment 207556 [details] Patch We're going to move GLTransportSurface to Source/WebCore/platform/graphics/surfaces instead
Alex Christensen
Comment 4 2013-07-29 13:10:40 PDT
Created attachment 207668 [details] Patch
Kalyan
Comment 5 2013-07-29 13:15:43 PDT
LGTM
WebKit Commit Bot
Comment 6 2013-07-29 15:39:01 PDT
Comment on attachment 207668 [details] Patch Clearing flags on attachment: 207668 Committed r153443: <http://trac.webkit.org/changeset/153443>
WebKit Commit Bot
Comment 7 2013-07-29 15:39:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.