Bug 119144

Summary: [EFL] Bump required version of EFL to 1.7
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ryuan Choi
Reported 2013-07-26 04:53:56 PDT
Bug 90076 added it with FIXME. Since EFL 1.7, it was fixed.(eina / r73320) So I believe that we can believe this now.
Attachments
Patch (1.81 KB, patch)
2013-07-26 04:58 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (5.27 KB, patch)
2013-07-27 21:06 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2013-07-26 04:58:04 PDT
Created attachment 207524 [details] Patch
Chris Dumez
Comment 2 2013-07-26 05:12:29 PDT
Comment on attachment 207524 [details] Patch Please update the following line in Source/cmake/OptionsEfl.cmake: find_package(Eina 1.6 REQUIRED) // we need to require 1.7 with your change.
Ryuan Choi
Comment 3 2013-07-26 05:30:07 PDT
(In reply to comment #2) > (From update of attachment 207524 [details]) > Please update the following line in Source/cmake/OptionsEfl.cmake: > find_package(Eina 1.6 REQUIRED) // we need to require 1.7 with your change. Hmm, I think that we can change minimum requirement to 1.7 It was changed because of tizen (at Bug 104431), but now Tizen used 1.7.X (In fact, they might print 1.8 as version) I will create another bug for it.
Chris Dumez
Comment 4 2013-07-26 05:34:14 PDT
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 207524 [details] [details]) > > Please update the following line in Source/cmake/OptionsEfl.cmake: > > find_package(Eina 1.6 REQUIRED) // we need to require 1.7 with your change. > > Hmm, I think that we can change minimum requirement to 1.7 > > It was changed because of tizen (at Bug 104431), but now Tizen used 1.7.X (In fact, they might print 1.8 as version) > > I will create another bug for it. I believe you can bump the dependency in the same patch. At least we would see the reason why the dependency is bumped.
Ryuan Choi
Comment 5 2013-07-27 21:06:18 PDT
Created attachment 207599 [details] Patch
Ryuan Choi
Comment 6 2013-07-27 21:07:58 PDT
(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > (From update of attachment 207524 [details] [details] [details]) > > > Please update the following line in Source/cmake/OptionsEfl.cmake: > > > find_package(Eina 1.6 REQUIRED) // we need to require 1.7 with your change. > > > > Hmm, I think that we can change minimum requirement to 1.7 > > > > It was changed because of tizen (at Bug 104431), but now Tizen used 1.7.X (In fact, they might print 1.8 as version) > > > > I will create another bug for it. > > I believe you can bump the dependency in the same patch. At least we would see the reason why the dependency is bumped. OK, I changed bug title and covered them. I thought that bumping is more important change so I changed bug title.
Chris Dumez
Comment 7 2013-07-27 23:20:10 PDT
Comment on attachment 207599 [details] Patch r=me.
Ryuan Choi
Comment 8 2013-07-27 23:24:36 PDT
Comment on attachment 207599 [details] Patch Thank you
WebKit Commit Bot
Comment 9 2013-07-27 23:47:22 PDT
Comment on attachment 207599 [details] Patch Clearing flags on attachment: 207599 Committed r153409: <http://trac.webkit.org/changeset/153409>
WebKit Commit Bot
Comment 10 2013-07-27 23:47:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.