Summary: | Add DRT test to ensure don't override z-index for overflow: scroll, -webkit-overflow-scrolling: touch | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||
Component: | Tools / Tests | Assignee: | Daniel Bates <dbates> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, simon.fraser | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Daniel Bates
2013-07-24 18:29:29 PDT
Created attachment 207426 [details]
Patch
Comment on attachment 207426 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207426&action=review > LayoutTests/compositing/overflow/should-not-override-z-index-for-element-with-non-auto-z-index-and-overflow-scroll-and-touch.html:32 > + testRunner.dumpAsText() Will add missing semicolon to the end of this line before I land this patch. Comment on attachment 207426 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207426&action=review > LayoutTests/compositing/overflow/should-not-override-z-index-for-element-with-non-auto-z-index-and-overflow-scroll-and-touch.html:50 > + document.body.appendChild(document.createTextNode(document.elementFromPoint(10, 10).innerText)); > + document.body.removeChild(document.getElementById("test-container")); This seems slightly convoluted. You could just do getElementFromPoint() and stuff "PASS" into a node if you hit the correct element. Or you could just make a ref test, since the visible ordering is also different. Created attachment 207428 [details]
Patch
Committed r153111: <http://trac.webkit.org/changeset/153111> |