Bug 119048

Summary: Web Inspector: control+clicking on a numeric token should not show the context menu
Product: WebKit Reporter: Antoine Quint <graouts>
Component: Web InspectorAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Antoine Quint
Reported 2013-07-24 10:32:38 PDT
This is a followup bug to https://bugs.webkit.org/show_bug.cgi?id=118896 where we introduced the drag-to-adjust behaviour for numeric tokens and a mode where pressing down the control modifier key would change the increment to 0.1 / px. In the case where you'd start dragging with the control modifier key pressed, the context menu would appear, which is not what we should do since we're engaging in a dragging operation.
Attachments
Patch (2.52 KB, patch)
2013-07-24 10:34 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-07-24 10:33:20 PDT
<rdar://problem/14535098>
Antoine Quint
Comment 2 2013-07-24 10:34:03 PDT
Created attachment 207404 [details] Patch
WebKit Commit Bot
Comment 3 2013-07-24 11:27:26 PDT
Comment on attachment 207404 [details] Patch Clearing flags on attachment: 207404 Committed r153091: <http://trac.webkit.org/changeset/153091>
WebKit Commit Bot
Comment 4 2013-07-24 11:27:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.