Bug 119046

Summary:

RenderMenuList computes the width of its longest option twice.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Layout and Rendering

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar, Performance

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+
Moon lander	none

Description Andreas Kling 2013-07-24 10:01:34 PDT

RenderMenuList computes the width of its longest option twice.

Comment 1 Radar WebKit Bug Importer 2013-07-24 10:02:27 PDT

<rdar://problem/14534679>

Comment 2 Andreas Kling 2013-07-24 10:05:10 PDT

Created attachment 207402 [details]
Patch

Comment 3 Darin Adler 2013-07-24 10:16:09 PDT

Comment on attachment 207402 [details]
Patch

The name m_optionsChanged seems poor. Changed since when? The name should mention width.

Comment 4 Andreas Kling 2013-07-24 10:33:05 PDT

Created attachment 207403 [details]
Moon lander

Comment 5 WebKit Commit Bot 2013-07-24 12:10:30 PDT

Comment on attachment 207403 [details]
Moon lander

Clearing flags on attachment: 207403

Committed r153094: <http://trac.webkit.org/changeset/153094>

Comment 6 WebKit Commit Bot 2013-07-24 12:10:33 PDT

All reviewed patches have been landed.  Closing bug.