Bug 119046

Summary: RenderMenuList computes the width of its longest option twice.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar, Performance
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
darin: review+
Moon lander none

Andreas Kling
Reported 2013-07-24 10:01:34 PDT
RenderMenuList computes the width of its longest option twice.
Attachments
Patch (1.31 KB, patch)
2013-07-24 10:05 PDT, Andreas Kling 		darin: review+
DetailsFormatted DiffDiff
Moon lander (2.71 KB, patch)
2013-07-24 10:33 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-07-24 10:02:27 PDT
<rdar://problem/14534679>
Andreas Kling
Comment 2 2013-07-24 10:05:10 PDT
Created attachment 207402 [details] Patch
Darin Adler
Comment 3 2013-07-24 10:16:09 PDT
Comment on attachment 207402 [details] Patch The name m_optionsChanged seems poor. Changed since when? The name should mention width.
Andreas Kling
Comment 4 2013-07-24 10:33:05 PDT
Created attachment 207403 [details] Moon lander
WebKit Commit Bot
Comment 5 2013-07-24 12:10:30 PDT
Comment on attachment 207403 [details] Moon lander Clearing flags on attachment: 207403 Committed r153094: <http://trac.webkit.org/changeset/153094>
WebKit Commit Bot
Comment 6 2013-07-24 12:10:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.