Summary: | [WK2] Move the implementation of WebEditorClient::checkTextOfParagraph to WebEditorClient.cpp | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kwang Yul Seo <skyul> | ||||
Component: | WebKit2 | Assignee: | Kwang Yul Seo <skyul> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, beidson, g.czajkowski, kling, koivisto | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 118643 | ||||||
Attachments: |
|
Description
Kwang Yul Seo
2013-07-23 22:26:53 PDT
Created attachment 207373 [details]
Patch
Thanks for taking it into consideration! The spelling methods in WebEditorClient.cpp send the message to UIProcess. IMHO would be nice to keep checkTextOfParagraph in WebEditorClient.cpp to avoid code duplication in platform specific files (WebEditorClientMac.mm, WebEditorClientEfl.cpp, WebEditorClientGtk.cpp etc). LGTM. Committed r153481: <http://trac.webkit.org/changeset/153481> |