Bug 119021 – The offsetLeft of rows should include border-spacing

• Component: Layout and Rendering
• Status: NEW

[Robert Hogan]

...

[Robert Hogan]

RenderTableSection.cpp:

 527     for (unsigned r = 0; r < totalRows; r++) {
 528         // Set the row's x/y position and width/height.
 529         if (RenderTableRow* rowRenderer = m_grid[r].rowRenderer) {
 530             // FIXME: the x() position of the row should be table()->hBorderSpacing() so that it can 
 531             // report the correct offsetLeft. However, that will require a lot of rebaselining of test results.
 532             rowRenderer->setLocation(LayoutPoint(0, m_rowPos[r]));

[Ahmad Saleem]

(In reply to Robert Hogan from comment #1)
> RenderTableSection.cpp:
> 
>  527     for (unsigned r = 0; r < totalRows; r++) {
>  528         // Set the row's x/y position and width/height.
>  529         if (RenderTableRow* rowRenderer = m_grid[r].rowRenderer) {
>  530             // FIXME: the x() position of the row should be
> table()->hBorderSpacing() so that it can 
>  531             // report the correct offsetLeft. However, that will
> require a lot of rebaselining of test results.
>  532             rowRenderer->setLocation(LayoutPoint(0, m_rowPos[r]));

We still have this:

https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderTableSection.cpp#559

[Karl Dubost]

*** Bug 119020 has been marked as a duplicate of this bug. ***

[Karl Dubost]

I get exactly the behavior described there in a patch but it doesn't fix everything yet. 
https://searchfox.org/wubkat/source/LayoutTests/fast/table/offset-top-includes-border.html#17

> The offsetTop of tbody, rows and cells should include the table's border. The tbody should include border-spacing in its offsetTop and offsetLeft too but that is a separate and more involved bug (webkit.org/b/119020) which when it's resolved should change the offsets from 14 to 19 for the tbody in this test. The offsetLeft for the row is also wrong (webkit.org/b/119021), fixing it will require a lot of rebaselining.

[Radar WebKit Bug Importer]

<rdar://problem/148517476>

[Karl Dubost]

Pull request: https://github.com/WebKit/WebKit/pull/43540