Bug 119007

Summary:

Add a test for plug-in unavailability indicator obscurity detection

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

Plug-ins

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, gordon_sheridan, gtk-ews, sfalken, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	gtk-ews: commit-queue-
fix gtk in theory	andersca: review+

Tim Horton

Reported 2013-07-23 02:14:19 PDT

Since we don't have any, I'm going to cover lots of cases in one big test.

Attachments
patch (22.54 KB, patch) 2013-07-23 02:17 PDT, Tim Horton	gtk-ews: commit-queue-	Details Formatted Diff Diff
fix gtk in theory (23.68 KB, patch) 2013-07-23 10:05 PDT, Tim Horton	andersca: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Tim Horton

Comment 1 2013-07-23 02:17:30 PDT

Created attachment 207315 [details] patch

Tim Horton

Comment 2 2013-07-23 02:19:45 PDT

Comment on attachment 207315 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=207315&action=review > LayoutTests/plugins/unavailable-plugin-indicator-obscurity.html:121 > + <div class="container"> > + <embed id="pointerEventsBlockedOnObscuringSibling" class="shouldNotBeObscured" type="application/x-webkit-test-netscape"></embed> > + <div class="cover" style="pointer-events: none;"></div> > + </div> I think the fact that this one passes is a bug (you can't see the plugin because it's covered up, but we think it's not covered because the thing that's covering it has pointer-events: none set on it). But I'll leave that for Gordon to decide and file a separate bug about...

kov's GTK+ EWS bot

Comment 3 2013-07-23 02:22:57 PDT

Comment on attachment 207315 [details] patch Attachment 207315 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1109099

Tim Horton

Comment 4 2013-07-23 02:31:51 PDT

(In reply to comment #3) > (From update of attachment 207315 [details]) > Attachment 207315 [details] did not pass gtk-ews (gtk): > Output: http://webkit-queues.appspot.com/results/1109099 I dunno what that's about, and the fact that the gtk-wk2 bot is happy makes me even more confused.

Tim Horton

Comment 5 2013-07-23 10:05:44 PDT

Created attachment 207337 [details] fix gtk in theory

Tim Horton

Comment 6 2013-07-23 10:13:51 PDT

http://trac.webkit.org/changeset/153054

Tim Horton

Comment 7 2013-07-31 12:27:35 PDT

(In reply to comment #2) > (From update of attachment 207315 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=207315&action=review > > > LayoutTests/plugins/unavailable-plugin-indicator-obscurity.html:121 > > + <div class="container"> > > + <embed id="pointerEventsBlockedOnObscuringSibling" class="shouldNotBeObscured" type="application/x-webkit-test-netscape"></embed> > > + <div class="cover" style="pointer-events: none;"></div> > > + </div> > > I think the fact that this one passes is a bug (you can't see the plugin because it's covered up, but we think it's not covered because the thing that's covering it has pointer-events: none set on it). But I'll leave that for Gordon to decide and file a separate bug about... I filed https://bugs.webkit.org/show_bug.cgi?id=119348 about this, and changed the test to fail that test case.

Note You need to log in before you can comment on or make changes to this bug.