Summary: | Windows build bustage | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Don Gibson <dgibson77> | ||||||||
Component: | WebCore Misc. | Assignee: | Don Gibson <dgibson77> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, gombi.webkit, webkit | ||||||||
Priority: | P2 | ||||||||||
Version: | 420+ | ||||||||||
Hardware: | PC | ||||||||||
OS: | Windows XP | ||||||||||
Attachments: |
|
Description
Don Gibson
2006-12-20 18:34:37 PST
Created attachment 11942 [details] patch for r18368 This fixes the build on my machine. Comment on attachment 11942 [details] patch for r18368 You used fillColor() by mistake for the rect fills of endpoints in drawLine. Even though "fill" is used to paint those it's a stroke and should be using strokeColor. Created attachment 12175 [details] patch for r18532 Updated to correct hyatt's review comment and fix more things broken since the last patch. Created attachment 12200 [details] patch for r18551 Updated to latest trunk Comment on attachment 12200 [details] patch for r18551 r=me JFYI, WebKit (debug) still doesn't link for me for whatever reason (missing fastMalloc/fastFree, WTFReportAssertionFailure, WebCore::contextMenuTemTagXXX). Committed revision 18579. |