Bug 11900

Summary: Windows build bustage
Product: WebKit Reporter: Don Gibson <dgibson77>
Component: WebCore Misc.Assignee: Don Gibson <dgibson77>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, gombi.webkit, webkit
Priority: P2    
Version: 420+   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
patch for r18368
hyatt: review-
patch for r18532
none
patch for r18551 ap: review+

Don Gibson
Reported 2006-12-20 18:34:37 PST
Patch coming shortly
Attachments
patch for r18368 (22.33 KB, patch)
2006-12-20 18:37 PST, Don Gibson 		hyatt: review-
DetailsFormatted DiffDiff
patch for r18532 (29.96 KB, patch)
2007-01-02 17:59 PST, Don Gibson 		no flags
DetailsFormatted DiffDiff
patch for r18551 (60.71 KB, patch)
2007-01-03 13:58 PST, Don Gibson 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Don Gibson
Comment 1 2006-12-20 18:37:19 PST
Created attachment 11942 [details] patch for r18368 This fixes the build on my machine.
Dave Hyatt
Comment 2 2006-12-20 20:33:57 PST
Comment on attachment 11942 [details] patch for r18368 You used fillColor() by mistake for the rect fills of endpoints in drawLine. Even though "fill" is used to paint those it's a stroke and should be using strokeColor.
Don Gibson
Comment 3 2007-01-02 17:59:59 PST
Created attachment 12175 [details] patch for r18532 Updated to correct hyatt's review comment and fix more things broken since the last patch.
Don Gibson
Comment 4 2007-01-03 13:58:11 PST
Created attachment 12200 [details] patch for r18551 Updated to latest trunk
Alexey Proskuryakov
Comment 5 2007-01-04 05:04:55 PST
Comment on attachment 12200 [details] patch for r18551 r=me JFYI, WebKit (debug) still doesn't link for me for whatever reason (missing fastMalloc/fastFree, WTFReportAssertionFailure, WebCore::contextMenuTemTagXXX).
Alexey Proskuryakov
Comment 6 2007-01-04 05:05:57 PST
Committed revision 18579.
Note You need to log in before you can comment on or make changes to this bug.