Bug 11900 - Windows build bustage
Summary: Windows build bustage
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 420+
Hardware: PC Windows XP
: P2 Normal
Assignee: Don Gibson
Depends on:
Reported: 2006-12-20 18:34 PST by Don Gibson
Modified: 2007-01-04 18:53 PST (History)
3 users (show)

See Also:

patch for r18368 (22.33 KB, patch)
2006-12-20 18:37 PST, Don Gibson
hyatt: review-
Details | Formatted Diff | Diff
patch for r18532 (29.96 KB, patch)
2007-01-02 17:59 PST, Don Gibson
no flags Details | Formatted Diff | Diff
patch for r18551 (60.71 KB, patch)
2007-01-03 13:58 PST, Don Gibson
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Gibson 2006-12-20 18:34:37 PST
Patch coming shortly
Comment 1 Don Gibson 2006-12-20 18:37:19 PST
Created attachment 11942 [details]
patch for r18368

This fixes the build on my machine.
Comment 2 Dave Hyatt 2006-12-20 20:33:57 PST
Comment on attachment 11942 [details]
patch for r18368

You used fillColor() by mistake for the rect fills of endpoints in drawLine.  Even though "fill" is used to paint those it's a stroke and should be using strokeColor.
Comment 3 Don Gibson 2007-01-02 17:59:59 PST
Created attachment 12175 [details]
patch for r18532

Updated to correct hyatt's review comment and fix more things broken since the last patch.
Comment 4 Don Gibson 2007-01-03 13:58:11 PST
Created attachment 12200 [details]
patch for r18551

Updated to latest trunk
Comment 5 Alexey Proskuryakov 2007-01-04 05:04:55 PST
Comment on attachment 12200 [details]
patch for r18551


JFYI, WebKit (debug) still doesn't link for me for whatever reason (missing fastMalloc/fastFree, WTFReportAssertionFailure, WebCore::contextMenuTemTagXXX).
Comment 6 Alexey Proskuryakov 2007-01-04 05:05:57 PST
Committed revision 18579.