| Summary: | Need ExpressionRangeInfo before ResolveForPuts in strict mode | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | fpizlo, ggaren, oliver | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 207299 [details] the patch This patch was already previously r+ by Oliver as part of a patch in https://bugs.webkit.org/show_bug.cgi?id=116853. Uploading it here as a stand alone patch so that it can be landed separately from the BinaryOpNode change in the original bug. Landed in r153074: <http://trac.webkit.org/changeset/153074>. Comment on attachment 207299 [details]
the patch
This patch was already previously reviewed by Oliver. So, I've landed it, and canceling the review.
|
If we add an assertion in UnlinkedCodeBlock::expressionRangeForBytecodeOffset() to ensure that we are able to find an ExpressionRangeInfo for any given bytecode, the following tests will fail: fast/js/basic-strict-mode.html fast/js/mozilla/strict/8.7.2.html We should emit expression info before calls to emitResolveBaseForPut() if we're in strict mode.