Bug 118985 – Missing forward declarations of the Range class in the Clipboard and Frame headers

• Component: New Bugs
• Status: RESOLVED INVALID

[Zan Dobersek]

Missing forward declarations of the Range class in the Clipboard and Frame headers

[Zan Dobersek]

Created attachment 207272 [details]
Patch

[Darin Adler]

Comment on attachment 207272 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207272&action=review

> Source/WebCore/ChangeLog:10
> +        Add forward declarations for the Range class to the Clipboard and Frame headers. This is currently
> +        not affecting compilation on any ports, but is relying on pure luck that a previously-included header
> +        also includes the Range header or that there was at least a previous forward declaration of the Range class.

I don’t think this is about “pure luck”. If these headers include a header that have a forward declaration, that’s sufficient, and we don’t add additional forward declarations. I think the real issue here is that you were removing a forward declaration from something else.

[Zan Dobersek]

The Range forward declaration is being removed from the DragImage header in bug #118981. That's causing compilation problems, as evident by the EWSs complaining in that bug.

The Clipboard an Frame headers get the forward declaration through including the DragImage header, but removing it from there means that it has to be reintroduced in both headers, which is what this patch tries to achieve.

I've accordingly set this bug to block bug #118981.

[Sam Weinig]

Comment on attachment 207272 [details]
Patch

I think putting both changes into one patch would better.  This patch alone is meaningless.

[Zan Dobersek]

Folding this into bug #118981.