Bug 118980

Summary: [GTK] Mock GDK_IS_X11_DISPLAY macro can be redefined unnecessarily
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 117895    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2013-07-22 13:23:43 PDT
[GTK] Mock GDK_IS_X11_DISPLAY macro can be redefined unnecessarily
Attachments
Patch (2.22 KB, patch)
2013-07-22 13:26 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-07-22 13:26:36 PDT
Created attachment 207268 [details] Patch
Carlos Garcia Campos
Comment 2 2013-07-22 23:04:37 PDT
Comment on attachment 207268 [details] Patch This is what I did in the stable branch, although I didn't reuse the previous #ifdef block. LGTM too, thanks for fixing it.
Zan Dobersek
Comment 3 2013-07-23 02:47:09 PDT
(In reply to comment #2) > (From update of attachment 207268 [details]) > This is what I did in the stable branch, although I didn't reuse the previous #ifdef block. LGTM too, thanks for fixing it. Didn't spot that patch. Would have used it otherwise.
Zan Dobersek
Comment 4 2013-07-23 02:48:24 PDT
Comment on attachment 207268 [details] Patch Clearing flags on attachment: 207268 Committed r153035: <http://trac.webkit.org/changeset/153035>
Zan Dobersek
Comment 5 2013-07-23 02:48:31 PDT
All reviewed patches have been landed. Closing bug.
Carlos Garcia Campos
Comment 6 2013-07-23 02:50:26 PDT
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 207268 [details] [details]) > > This is what I did in the stable branch, although I didn't reuse the previous #ifdef block. LGTM too, thanks for fixing it. > > Didn't spot that patch. Would have used it otherwise. I actually fixed it directly when merging the original commit. I prefer your patch that reuses the ifdef block, so no problem.
Note You need to log in before you can comment on or make changes to this bug.