Bug 118953

Summary:

Java Updater not launched on Lion and Mountain Lion

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+

Description Anders Carlsson 2013-07-21 11:47:48 PDT

Java Updater not launched on Lion and Mountain Lion

Comment 1 Anders Carlsson 2013-07-21 11:49:04 PDT

Created attachment 207210 [details]
Patch

Comment 2 Sam Weinig 2013-07-21 11:50:46 PDT

Comment on attachment 207210 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207210&action=review

> Source/WebKit2/UIProcess/Plugins/mac/PluginProcessProxyMac.mm:413
> +    NSURL *url = [NSURL URLWithString:urlString];
> +    if (![url isFileURL])
> +        return false;
>  
> -    return [[NSURL URLWithString:urlString] isEqual:javaUpdaterURL];
> +    NSString *javaUpdaterPath = [NSString pathWithComponents:[NSArray arrayWithObjects:(NSString *)pluginProcessAttributes.moduleInfo.path, @"Contents/Resources/Java Updater.app", nil]];
> +    return [url.path isEqualToString:javaUpdaterPath];

This could either use a comment.

Comment 3 Anders Carlsson 2013-07-21 11:54:26 PDT

Committed r152950: <http://trac.webkit.org/changeset/152950>