Bug 118923

Summary: JIT::updateTopCallFrame doesn't update the CallFrame's bytecodeOffset if bytecodeOffset == 0
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Mark Hahnenberg
Reported 2013-07-19 14:55:51 PDT
This causes the CallFrame's bytecodeOffset to not be properly set when we enter, e.g., cti_optimize from an op_enter.
Attachments
Patch (1.73 KB, patch)
2013-07-22 15:15 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2013-07-19 14:56:45 PDT
This isn't currently a big deal since cti_optimize takes the bytecode offset as its argument, but it will be important for bytecode-liveness-based JSStack scans for GC.
Mark Hahnenberg
Comment 2 2013-07-22 15:15:09 PDT
Created attachment 207285 [details] Patch
WebKit Commit Bot
Comment 3 2013-07-24 12:55:43 PDT
Comment on attachment 207285 [details] Patch Clearing flags on attachment: 207285 Committed r153097: <http://trac.webkit.org/changeset/153097>
WebKit Commit Bot
Comment 4 2013-07-24 12:55:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.