Bug 118911

Summary: fourthTier: Structure::isValidOffset() should be able to tell you if you're loading a valid JSValue, and not just not crashing
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch ggaren: review+

Filip Pizlo
Reported 2013-07-19 11:18:35 PDT
We could also have a separate method like "willNotCrash(offset)", but that's not what isValidOffset() is intended to mean.
Attachments
the patch (1.57 KB, patch)
2013-07-19 11:19 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-07-19 11:19:43 PDT
Created attachment 207127 [details] the patch
Geoffrey Garen
Comment 2 2013-07-19 13:39:23 PDT
Comment on attachment 207127 [details] the patch r=me
Filip Pizlo
Comment 3 2013-07-19 19:52:32 PDT
Landed in http://trac.webkit.org/changeset/152937
Note You need to log in before you can comment on or make changes to this bug.