Summary: | Visual Studio files need x64 configuration | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||
Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bfulgham, commit-queue | ||||||||
Priority: | P3 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Windows 7 | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 61553 | ||||||||||
Attachments: |
|
Description
Alex Christensen
2013-07-18 21:35:24 PDT
Created attachment 207057 [details]
patch
Comment on attachment 207057 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=207057&action=review Wow! That was a big patch, but it looks good. I made a few notes for future reference; we should try to clean them up as we make actual configuration changes to support 64-bit. > Source/JavaScriptCore/JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj:105 > + <Import Project="$(WebKit_Libraries)\tools\vsprops\common.props" /> When I did this locally, I needed to make a "common_x64.props" file. We'll probably need to do something like this in your second bug. > Source/WTF/WTF.vcxproj/WTF.vcxproj.filters:217 > + <ClCompile Include="..\wtf\text\AtomicStringTable.cpp" /> Interesting -- I wonder why this was missing before your patch? > Source/WebKit/WebKit.vcxproj/Interfaces/Interfaces.vcxproj:185 > + <WarningLevel>Level3</WarningLevel> Note: We should be setting this stuff in a property sheet! Reminder for later :-) > Source/WebKit/WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters:12 > + <ClCompile Include="$(ConfigurationBuildDir)\obj32\WebKit\Interfaces\AccessibleRelation_i.c" /> Good catch! We'll need to make sure we have obj64 cases soon... > Tools/DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:108 > + <ClCompile Include="..\..\JavaScriptThreading.cpp" /> Huh. Wonder why this wasn't already in the filters file? > Tools/DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:171 > + <AdditionalOptions>/SAFESEH %(AdditionalOptions)</AdditionalOptions> Seems like this should be in a property sheet. Note for future work! Comment on attachment 207057 [details] patch Rejecting attachment 207057 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 207057, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/1132195 Created attachment 207130 [details]
patch
Comment on attachment 207130 [details] patch Rejecting attachment 207130 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 207130, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: roj patch: **** malformed patch at line 7: patching file Tools/WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj patch: **** malformed patch at line 7: patching file Tools/win/AssembleBuildLogs/AssembleBuildLogs.vcxproj patch: **** malformed patch at line 7: patching file Tools/win/record-memory/record-memory.vcxproj patch: **** malformed patch at line 7: Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/1100870 Created attachment 207133 [details]
Patch
Comment on attachment 207133 [details]
Patch
r=me
Comment on attachment 207133 [details] Patch Clearing flags on attachment: 207133 Committed r152921: <http://trac.webkit.org/changeset/152921> All reviewed patches have been landed. Closing bug. |