Bug 118885

Summary: String::lower() - Skip to slow path on the first failure
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, barraclough, cmarcelo, commit-queue, darin, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Benjamin Poulain
Reported 2013-07-18 20:56:03 PDT
String::lower() - Skip to slow patch on the first failure
Attachments
Patch (3.07 KB, patch)
2013-07-18 20:58 PDT, Benjamin Poulain 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2013-07-18 20:58:18 PDT
Created attachment 207055 [details] Patch
Benjamin Poulain
Comment 2 2013-07-22 15:01:21 PDT
Comment on attachment 207055 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207055&action=review > Source/WTF/ChangeLog:3 > + String::lower() - Skip to slow patch on the first failure Note to self: fix the changlog!
Benjamin Poulain
Comment 3 2013-07-22 15:29:29 PDT
Committed r153007: <http://trac.webkit.org/changeset/153007>
Darin Adler
Comment 4 2013-08-09 13:55:49 PDT
Did this slow down the “already all lowercase” case? How did you measure that?
Benjamin Poulain
Comment 5 2013-08-09 15:07:59 PDT
(In reply to comment #4) > Did this slow down the “already all lowercase” case? I could not measure any difference for the fast path on x86_64 and ARM. > How did you measure that? Through the JS API with String.toLowerCase() with an ad-hoc benchmark.
Note You need to log in before you can comment on or make changes to this bug.