Summary: | New PDFPlugin doesn't support WebKitOmitPDFSupport, acts as if Plug-ins are off | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||
Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, buildbot, commit-queue, eric.carlson, glenn, rniwa, thorton | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Jer Noble
2013-07-18 11:26:56 PDT
Created attachment 207004 [details]
Patch
Comment on attachment 207004 [details] Patch Attachment 207004 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1095562 Comment on attachment 207004 [details] Patch Attachment 207004 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1090969 Created attachment 207015 [details]
Patch for committing.
Comment on attachment 207015 [details] Patch for committing. View in context: https://bugs.webkit.org/attachment.cgi?id=207015&action=review > Source/WebCore/ChangeLog:3 > + New PDFPlugin doesn't support WebKitOmitPDFSupport, acts as if Plug-ins are off Does it not? I think that it might be reading defaults from a different process though. Comment on attachment 207015 [details] Patch for committing. Clearing flags on attachment: 207015 Committed r152867: <http://trac.webkit.org/changeset/152867> Cleared cq flag for discussion, but it was too late to stop the queue. Would also like new PDFPlugin author to weigh in. (In reply to comment #5) > (From update of attachment 207015 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=207015&action=review > > > Source/WebCore/ChangeLog:3 > > + New PDFPlugin doesn't support WebKitOmitPDFSupport, acts as if Plug-ins are off > > Does it not? I think that it might be reading defaults from a different process though. We're not reading the defaults from different processes. See <rdar://problem/13478932> for discussion. Thanks, jer! > We're not reading the defaults from different processes. See <rdar://problem/13478932> for discussion.
So what are we doing in WebPage::platformPreferencesDidChange()?
BOOL omitPDFSupport = [[NSUserDefaults standardUserDefaults] boolForKey:@"WebKitOmitPDFSupport"];
(In reply to comment #10) > > We're not reading the defaults from different processes. See <rdar://problem/13478932> for discussion. > > So what are we doing in WebPage::platformPreferencesDidChange()? > > BOOL omitPDFSupport = [[NSUserDefaults standardUserDefaults] boolForKey:@"WebKitOmitPDFSupport"]; That code is not in the tree anymore: http://trac.webkit.org/changeset/152841/trunk/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm |