Bug 118848

Summary: Use [ImplementedAs] instead of special casing in the bindings generators
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, d-r, esprehn+autocc, fmalita, haraken, laszlo.gombos, pdr, rniwa, schenney
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2013-07-18 06:20:52 PDT
In several instances, special casing is used in the bindings generator to avoid name clashes in the implementation. The [ImplementedBy] IDL extended attribute is meant to solve this issue so we should use it instead. Corresponding Blink revisions: https://src.chromium.org/viewvc/blink?revision=154303&view=revision https://src.chromium.org/viewvc/blink?revision=154309&view=revision https://src.chromium.org/viewvc/blink?revision=154341&view=revision
Attachments
Patch (18.89 KB, patch)
2013-07-18 06:24 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-07-18 06:24:11 PDT
Created attachment 206987 [details] Patch
Kentaro Hara
Comment 2 2013-07-18 06:29:55 PDT
Comment on attachment 206987 [details] Patch Looks like a good refactoring.
WebKit Commit Bot
Comment 3 2013-07-18 07:23:37 PDT
Comment on attachment 206987 [details] Patch Clearing flags on attachment: 206987 Committed r152844: <http://trac.webkit.org/changeset/152844>
WebKit Commit Bot
Comment 4 2013-07-18 07:23:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.