Bug 118833

Summary: WebKit should include remaining ANGLE source files
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: ANGLEAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch none

Alex Christensen
Reported 2013-07-17 22:36:51 PDT
WebGL on Windows requires ANGLE source files that were previously not included in the WebKit repository. These files should be included.
Attachments
Patch (1.13 MB, patch)
2013-07-17 22:40 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-07-17 22:40:46 PDT
Created attachment 206950 [details] Patch
Alex Christensen
Comment 2 2013-07-17 23:25:12 PDT
I'm not sure why it thinks the Visual Studio project files are binary, or if that's a problem. For some reason the execute bits of the files are set. Should I chmod everything before adding, after adding, or not at all? It might be nice to keep as much in common with the ANGLE repository as possible, but I'll have to edit the project files.
Dean Jackson
Comment 3 2013-07-18 13:46:47 PDT
Comment on attachment 206950 [details] Patch rs=me
WebKit Commit Bot
Comment 4 2013-07-18 14:11:17 PDT
Comment on attachment 206950 [details] Patch Clearing flags on attachment: 206950 Committed r152863: <http://trac.webkit.org/changeset/152863>
WebKit Commit Bot
Comment 5 2013-07-18 14:11:19 PDT
All reviewed patches have been landed. Closing bug.
Dean Jackson
Comment 6 2013-07-20 15:26:26 PDT
Rolled out in https://trac.webkit.org/r152946
Alex Christensen
Comment 7 2013-08-20 09:09:37 PDT
This was added in r152863, rolled out in r152946, and correctly added again in r153064.
Note You need to log in before you can comment on or make changes to this bug.