Bug 118826

Summary: [EFL] Unreviewed gardening
Product: WebKit Reporter: Seokju Kwon <seokju>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, fred.wang, gyuyoung.kim, lucas.de.marchi, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
patch for landing none

Seokju Kwon
Reported 2013-07-17 19:34:17 PDT
Update test expectations after r134890 and r139491. (Remove two tests from efl-wk2/TestExpectations) webkit.org/b/90207 fast/forms/select/select-state-restore.html [ Failure Pass ] webkit.org/b/98722 [ Debug ] fast/dom/gc-acid3.html [ Crash Pass ] And remove mathml/presentation/over.xhtml. Path does not exist. mathml/presentation/over.xhtml
Attachments
Patch (2.57 KB, patch)
2013-07-17 19:40 PDT, Seokju Kwon 		no flags
DetailsFormatted DiffDiff
patch for landing (1.70 KB, patch)
2013-07-24 00:37 PDT, Seokju Kwon 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Seokju Kwon
Comment 1 2013-07-17 19:40:48 PDT
Created attachment 206942 [details] Patch
Frédéric Wang (:fredw)
Comment 2 2013-07-24 00:16:31 PDT
The MathML test was handled in bug 118916.
WebKit Commit Bot
Comment 3 2013-07-24 00:27:54 PDT
Comment on attachment 206942 [details] Patch Rejecting attachment 206942 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 206942, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 3 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/efl-wk2/TestExpectations patching file LayoutTests/platform/efl/TestExpectations Hunk #1 FAILED at 1021. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/efl/TestExpectations.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/1196097
Seokju Kwon
Comment 4 2013-07-24 00:29:43 PDT
(In reply to comment #3) > (From update of attachment 206942 [details]) > Rejecting attachment 206942 [details] from commit-queue. > > Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 206942, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit > > Last 500 characters of output: > 1 cwd: /Volumes/Data/EWS/WebKit > > Parsed 3 diffs from patch file(s). > patching file LayoutTests/ChangeLog > Hunk #1 succeeded at 1 with fuzz 3. > patching file LayoutTests/platform/efl-wk2/TestExpectations > patching file LayoutTests/platform/efl/TestExpectations > Hunk #1 FAILED at 1021. > 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/efl/TestExpectations.rej > > Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit > > Full output: http://webkit-queues.appspot.com/results/1196097 mathml/presentation/over.xhtml was removed after bug 118916. I will rebase it.
Seokju Kwon
Comment 5 2013-07-24 00:37:41 PDT
Created attachment 207377 [details] patch for landing
Seokju Kwon
Comment 6 2013-07-24 01:49:59 PDT
@Christophe Dumez Could you cq+ on this again?
WebKit Commit Bot
Comment 7 2013-07-24 02:35:07 PDT
Comment on attachment 207377 [details] patch for landing Clearing flags on attachment: 207377 Committed r153079: <http://trac.webkit.org/changeset/153079>
WebKit Commit Bot
Comment 8 2013-07-24 02:35:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.