Bug 118810

Summary:

CSS_SHAPES not supported on AppleWin port

Product:

WebKit

Reporter:

Roger Fong <roger_fong>

Component:

CSS

Assignee:

Bear Travis <betravis>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

betravis, buildbot, commit-queue, esprehn+autocc, glenn, macpherson, menard, rniwa, roger_fong, syoichi, zoltan

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Bug Depends on:

121871, 121879

Bug Blocks:

89256

Attachments:

Description	Flags
Initial Patch	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion	none
Updated patch	bfulgham: review+

Roger Fong

Reported 2013-07-17 14:17:56 PDT

Might want to consider getting this working on the Win port at some point.

Attachments
Initial Patch (20.65 KB, patch) 2013-09-13 11:48 PDT, Bear Travis	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (655.56 KB, application/zip) 2013-09-13 13:26 PDT, Build Bot	no flags	Details
Updated patch (20.56 KB, patch) 2013-09-16 12:54 PDT, Bear Travis	bfulgham: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Bear Travis

Comment 1 2013-09-13 11:48:47 PDT

Created attachment 211573 [details] Initial Patch A first attempt at enabling shapes on Windows.

Build Bot

Comment 2 2013-09-13 13:26:33 PDT

Comment on attachment 211573 [details] Initial Patch Attachment 211573 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1877096 New failing tests: svg/batik/filters/feTile.svg

Build Bot

Comment 3 2013-09-13 13:26:34 PDT

Created attachment 211583 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Bear Travis

Comment 4 2013-09-16 12:54:30 PDT

Created attachment 211824 [details] Updated patch

Brent Fulgham

Comment 5 2013-09-18 15:41:16 PDT

Comment on attachment 211824 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=211824&action=review Looks good. When you land it, could you please make sure you add this to the WinCairo target as well? > Source/WebCore/ChangeLog:10 > + * WebCore.vcxproj/WebCore.vcxproj: Add missing shape includes. There should ideally be some changes to WebCore.vcxproj/WebCore.vcxproj.filters here as well, but you won't get them if you edit the XML outside of Visual Studio. It's self-healing, so not a big deal. > WebKitLibraries/ChangeLog:8 > + * win/tools/vsprops/FeatureDefines.props: Add the CSS_SHAPES compile flag on Windows. Please add this to win/tools/vsprops/FeatureDefinesWinCairo.props as well. > WebKitLibraries/win/tools/vsprops/FeatureDefines.props:21 > + <ENABLE_CSS_SHAPES>ENABLE_CSS_SHAPES</ENABLE_CSS_SHAPES> Ditto my above comment. > WebKitLibraries/win/tools/vsprops/FeatureDefines.props:94 > + <PreprocessorDefinitions>$(ENABLE_IFRAME_SEAMLESS);$(ENABLE_PROMISES);$(ENABLE_REQUEST_ANIMATION_FRAME);$(ENABLE_3D_RENDERING);$(ENABLE_ACCELERATED_2D_CANVAS);$(ENABLE_ACCELERATED_OVERFLOW_SCROLLING);$(ENABLE_BLOB);$(ENABLE_CANVAS_PROXY);$(ENABLE_CHANNEL_MESSAGING);$(ENABLE_CSS3_CONDITIONAL_RULES);$(ENABLE_CSS_IMAGE_SET);$(ENABLE_CSS3_TEXT);$(ENABLE_CSS_BOX_DECORATION_BREAK);$(ENABLE_CSS_FILTERS);$(ENABLE_CSS_GRID_LAYOUT);$(ENABLE_CSS_SHADERS);$(ENABLE_CSS_COMPOSITING);$(ENABLE_CSS_REGIONS);$(ENABLE_CSS_EXCLUSIONS);$(ENABLE_CSS_SHAPES);$(ENABLE_CSS_STICKY_POSITION);$(ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED);$(ENABLE_CUSTOM_SCHEME_HANDLER);$(ENABLE_SQL_DATABASE);$(ENABLE_DATAGRID);$(ENABLE_DATALIST_ELEMENT);$(ENABLE_DATA_TRANSFER_ITEMS);$(ENABLE_DETAILS_ELEMENT);$(ENABLE_DEVICE_ORIENTATION);$(ENABLE_DIRECTORY_UPLOAD);$(ENABLE_FILTERS);$(ENABLE_FILE_SYSTEM);$(ENABLE_FULLSCREEN_API);$(ENABLE_GAMEPAD);$(ENABLE_GEOLOCATION);$(ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING);$(ENABLE_HIGH_DPI_CANVAS);$(ENABLE_ICONDATABASE);$(ENABLE_INDEXED_DATABASE);$(ENABLE_INPUT_TYPE_COLOR);$(ENABLE_INPUT_SPEECH);$(ENABLE_INPUT_TYPE_DATE);$(ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE);$(ENABLE_INPUT_TYPE_DATETIMELOCAL);$(ENABLE_INPUT_TYPE_MONTH);$(ENABLE_INPUT_TYPE_TIME);$(ENABLE_INPUT_TYPE_WEEK);$(ENABLE_JAVASCRIPT_DEBUGGER);$(ENABLE_LEGACY_CSS_VENDOR_PREFIXES);$(ENABLE_LEGACY_NOTIFICATIONS);$(ENABLE_LINK_PREFETCH);$(ENABLE_LINK_PRERENDER);$(ENABLE_MATHML);$(ENABLE_METER_ELEMENT);$(ENABLE_MICRODATA);$(ENABLE_NOTIFICATIONS);$(ENABLE_PAGE_VISIBILITY_API);$(ENABLE_PROGRESS_ELEMENT);$(ENABLE_PROXIMITY_EVENTS);$(ENABLE_QUOTA);$(ENABLE_NAVIGATOR_CONTENT_UTILS);$(ENABLE_SCRIPTED_SPEECH);$(ENABLE_SHADOW_DOM);$(ENABLE_SHARED_WORKERS);$(ENABLE_STYLE_SCOPED);$(ENABLE_SVG);$(ENABLE_SVG_DOM_OBJC_BINDINGS);$(ENABLE_SVG_FONTS);$(ENABLE_SUBPIXEL_LAYOUT);$(ENABLE_TEXT_AUTOSIZING);$(ENABLE_UNDO_MANAGER);$(ENABLE_VIDEO);$(ENABLE_VIDEO_TRACK);$(ENABLE_VIEW_MODE_CSS_MEDIA);$(ENABLE_MEDIA_SOURCE);$(ENABLE_MEDIA_STATISTICS);$(ENABLE_WEB_SOCKETS);$(ENABLE_WEB_TIMING);$(ENABLE_WORKERS);$(ENABLE_XSLT);%(PreprocessorDefinitions)</PreprocessorDefinitions> Ditto my above comment. > WebKitLibraries/win/tools/vsprops/FeatureDefines.props:169 > + </BuildMacro> Again.

Bear Travis

Comment 6 2013-09-19 14:30:27 PDT

Manually committed in r156116 https://trac.webkit.org/r156116

WebKit Commit Bot

Comment 7 2013-09-24 15:23:20 PDT

Re-opened since this is blocked by bug 121871

Bear Travis

Comment 8 2013-11-08 17:29:33 PST

The build settings are still in place, they just had to be disabled until bug 121883 was fixed. Marking as a duplicate of bug 89957, which will just toggle support back on. *** This bug has been marked as a duplicate of bug 89957 ***

Note You need to log in before you can comment on or make changes to this bug.