REGRESSION (r18304): Assertion failure in -[WebHTMLView _canProcessDragWithDraggingInfo:] when dragging over the window's a scroll bar (innerFrame)

• Component: Frames
• Status: RESOLVED FIXED

To reproduce: with a debug build of TOT, open the URL and drag the image outside of the window.

ASSERTION FAILED: innerFrame
(WebKit/WebView/WebHTMLView.m:5937 -[WebHTMLView(WebDocumentInternalProtocols) _canProcessDragWithDraggingInfo:])

Doesn't happen if the window doesn't have a scrollbar.

You actually need to move the mouse pointer over the scrollbar to hit the assert.

This is a regression from the fix for bug 8137. Specifically, EventHandler::hitTestResultAtPoint() sets the 'active' flag in the request but not the 'capturing' flag, and because of the following change in layer hit testing, it gets a null result instead of getting the document:

-    if (request.active && renderer()->isRenderView()) {
+    if (request.capturing && renderer()->isRenderView()) {

[Geoffrey Garen]

Created attachment 11923 [details]
fix w/changelog

[Darin Adler]

Comment on attachment 11923 [details]
fix w/changelog

+    if (request.active || request.mouseUp && renderer()->isRenderView()) {

I think you need parentheses here around the (active || mouseUp) part.

[Geoffrey Garen]

Created attachment 11924 [details]
fix w/changelog

doh!

[Darin Adler]

Comment on attachment 11924 [details]
fix w/changelog

A little subtle, but seems good for now. r=me

[Geoffrey Garen]

r18327.