Bug 118796

Summary: [EFL][WK2] Replace mouseClick with more meaningful method in test_ewk2_context_menu.cpp
Product: WebKit Reporter: Donggwan Kim <donggwan.kim>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, gyuyoung.kim, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch none

Donggwan Kim
Reported 2013-07-17 04:32:29 PDT
Some mouseClick methods are used in test_ewk2_context_menu.cpp. But it is difficult to understand what they mean. So i would like to replace those with more meaningful method for readability.
Attachments
Patch (5.17 KB, patch)
2013-07-17 17:49 PDT, Donggwan Kim 		no flags
DetailsFormatted DiffDiff
Patch (5.16 KB, patch)
2013-07-18 00:19 PDT, Donggwan Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Donggwan Kim
Comment 1 2013-07-17 17:49:06 PDT
Created attachment 206938 [details] Patch
Chris Dumez
Comment 2 2013-07-18 00:09:41 PDT
Comment on attachment 206938 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206938&action=review r=me. > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:187 > + mouseClick(10, 20, 3); Please keep the /* Right */ comment.
Donggwan Kim
Comment 3 2013-07-18 00:19:13 PDT
Created attachment 206956 [details] Patch
Donggwan Kim
Comment 4 2013-07-18 00:22:27 PDT
(In reply to comment #2) > (From update of attachment 206938 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=206938&action=review > > r=me. > > > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:187 > > + mouseClick(10, 20, 3); > > Please keep the /* Right */ comment. Done
WebKit Commit Bot
Comment 5 2013-07-18 01:00:06 PDT
Comment on attachment 206956 [details] Patch Clearing flags on attachment: 206956 Committed r152835: <http://trac.webkit.org/changeset/152835>
WebKit Commit Bot
Comment 6 2013-07-18 01:00:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.