Bug 118778

Summary: fourthTier: Add a phase to create loop pre-headers
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 118749    
Attachments:
Description Flags
the patch oliver: review+

Description Filip Pizlo 2013-07-16 22:18:36 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2013-07-16 22:24:48 PDT 
Created attachment 206854 [details]
the patch
Comment 2 Geoffrey Garen 2013-07-17 13:23:52 PDT 
Comment on attachment 206854 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206854&action=review

> Source/JavaScriptCore/dfg/DFGNaturalLoops.h:63
> +    // a natural loop. It's faster to call 

The suspense is killing me. Faster to call what?
Comment 3 Filip Pizlo 2013-07-17 14:02:13 PDT 
Comment on attachment 206854 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206854&action=review

>> Source/JavaScriptCore/dfg/DFGNaturalLoops.h:63
>> +    // a natural loop. It's faster to call 
> 
> The suspense is killing me. Faster to call what?

Lol.  It's faster to call NaturalLoops::belongsTo().  I'll fix that comment.
Comment 4 Filip Pizlo 2013-07-17 22:15:09 PDT 
Landed in http://trac.webkit.org/changeset/152829