Bug 118753

Summary: Typo in DFGInsertionSet.h header guard: "DFGInsectionSet_h" -> "DFGInsertionSet_h"
Product: WebKit Reporter: David Farler <dfarler>
Component: JavaScriptCoreAssignee: David Farler <dfarler>
Status: RESOLVED FIXED    
Severity: Minor    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch ggaren: review+

David Farler
Reported 2013-07-16 16:18:02 PDT
DFGInsertionSet.h: 26 #ifndef DFGInsertionSet_h 27 #define DFGInsectionSet_h Found this with trunk clang [-Wheader-guard] In file included from /webkit/OpenSource/Source/JavaScriptCore/dfg/DFGDCEPhase.cpp:33: /webkit/OpenSource/Source/JavaScriptCore/dfg/DFGInsertionSet.h:26:9: error: 'DFGInsertionSet_h' is used as a header guard here, followed by #define of a different macro [-Werror,-Wheader-guard] #ifndef DFGInsertionSet_h ^~~~~~~~~~~~~~~~~ /webkit/OpenSource/Source/JavaScriptCore/dfg/DFGInsertionSet.h:27:9: note: 'DFGInsectionSet_h' is defined here; did you mean 'DFGInsertionSet_h'? #define DFGInsectionSet_h ^~~~~~~~~~~~~~~~~ DFGInsertionSet_h 1 error generated.
Attachments
Patch (1.14 KB, patch)
2013-07-16 16:20 PDT, David Farler 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Farler
Comment 1 2013-07-16 16:20:21 PDT
Created attachment 206824 [details] Patch
Geoffrey Garen
Comment 2 2013-07-16 16:22:22 PDT
Comment on attachment 206824 [details] Patch r=me
David Farler
Comment 3 2013-07-16 16:23:10 PDT
Committed r152747: <http://trac.webkit.org/changeset/152747>
Note You need to log in before you can comment on or make changes to this bug.