Bug 118727

Summary: Use toHTMLMediaElement
Product: WebKit Reporter: Kangil Han <kangil.han>
Component: WebCore Misc.Assignee: Kangil Han <kangil.han>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling, koivisto, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Kangil Han
Reported 2013-07-16 04:04:17 PDT
Use toHTMLMediaElement and remove isMediaElement
Attachments
Patch (26.21 KB, patch)
2013-07-16 04:07 PDT, Kangil Han 		no flags
DetailsFormatted DiffDiff
Patch (25.13 KB, patch)
2013-07-16 06:45 PDT, Kangil Han 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kangil Han
Comment 1 2013-07-16 04:07:13 PDT
Created attachment 206755 [details] Patch
Ryosuke Niwa
Comment 2 2013-07-16 05:22:15 PDT
Comment on attachment 206755 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206755&action=review > Source/WebCore/html/HTMLTrackElement.cpp:90 > + if (!parentNode() && insertionPoint->isElementNode() && toElement(insertionPoint)->isMediaElement()) I don't think removing isMediaElement is a good idea in this case.
Kangil Han
Comment 3 2013-07-16 06:45:35 PDT
Created attachment 206776 [details] Patch
Kangil Han
Comment 4 2013-07-16 06:46:18 PDT
(In reply to comment #2) > (From update of attachment 206755 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=206755&action=review > > > Source/WebCore/html/HTMLTrackElement.cpp:90 > > + if (!parentNode() && insertionPoint->isElementNode() && toElement(insertionPoint)->isMediaElement()) > > I don't think removing isMediaElement is a good idea in this case. Done, thx! :) Took Ryosuke's comment into consideration.
WebKit Commit Bot
Comment 5 2013-07-17 00:10:55 PDT
Comment on attachment 206776 [details] Patch Clearing flags on attachment: 206776 Committed r152763: <http://trac.webkit.org/changeset/152763>
WebKit Commit Bot
Comment 6 2013-07-17 00:10:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.