Bug 118725

Summary:

[Qt] syncqt doesn't generate the forwarding headers in SVN repositories.

Product:

WebKit

Reporter:

Ádám Kallai <kadam>

Component:

Tools / Tests

Assignee:

Ádám Kallai <kadam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abecsi, abrhm, allan.jensen, jturcotte, ossy, vestbo, zarvai

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

114171

Attachments:

Description	Flags
proposed patch	vestbo: review-
proposed patch	none
proposed patch	vestbo: review+

Ádám Kallai

Reported 2013-07-16 02:35:58 PDT

The problem is that after this change impossible to build WebKit trunk with Qt 5.1. The problem is the svn. If we use svn repository then the syncqt won't generate the forwarding headers and the build will be wrong because of missing header files. Oswald Buddenhagen suggested this change. https://bugreports.qt-project.org/browse/QTBUG-29465

Attachments
proposed patch (955 bytes, patch) 2013-07-16 04:52 PDT, Ádám Kallai	vestbo: review-	Details Formatted Diff Diff
proposed patch (1.00 KB, patch) 2013-07-16 05:02 PDT, Ádám Kallai	no flags	Details Formatted Diff Diff
proposed patch (1.04 KB, patch) 2013-07-17 05:53 PDT, Ádám Kallai	vestbo: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Ádám Kallai

Comment 1 2013-07-16 04:52:14 PDT

Created attachment 206764 [details] proposed patch

Csaba Osztrogonác

Comment 2 2013-07-16 04:55:55 PDT

Comment on attachment 206764 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=206764&action=review LGTM, but it would be great if Tor Arne can do the final review. > .qmake.conf:6 > +#The syncqt can generate the forwarding headers in SVN repositories. > +CONFIG+=git_build It would be great to have a more descriptive comment here, for example same as in the changelog: # Workaround to make syncqt run and generate forwarding headers in SVN repositories too # https://bugs.webkit.org/show_bug.cgi?id=118725

Ádám Kallai

Comment 3 2013-07-16 05:02:52 PDT

Created attachment 206767 [details] proposed patch Ossy, thanks for the informal review. I corrected the comment.

Tor Arne Vestbø

Comment 4 2013-07-16 07:15:55 PDT

Comment on attachment 206764 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=206764&action=review >> .qmake.conf:6 >> +CONFIG+=git_build > > It would be great to have a more descriptive comment here, for example same as in the changelog: > # Workaround to make syncqt run and generate forwarding headers in SVN repositories too > # https://bugs.webkit.org/show_bug.cgi?id=118725 I agree with Ossy about the comment. This should also be guarded by a check for an actual .svn directory.

Ádám Kallai

Comment 5 2013-07-17 05:53:50 PDT

Created attachment 206886 [details] proposed patch I updated the patch. What do you think? Is it good?

Tor Arne Vestbø

Comment 6 2013-07-29 03:45:24 PDT

Comment on attachment 206886 [details] proposed patch Style issues aside (no spaces around arguments), lgtm

Ádám Kallai

Comment 7 2013-07-30 06:33:06 PDT

Committed r153467: <http://trac.webkit.org/changeset/153467>

Note You need to log in before you can comment on or make changes to this bug.