Bug 118723

Summary:

[CSS Regions] Convert percentage-margins-* tests to ref-tests

Product:

WebKit

Reporter:

Andrei Bucur <abucur>

Component:

WebKit Misc.

Assignee:

Andrei Bucur <abucur>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, gyuyoung.kim, mihnea, rakuco, WebkitBugTracker

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

118975

Bug Blocks:

57312

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Andrei Bucur

Reported 2013-07-16 02:21:31 PDT

fast/regions/percentage-margins-variable-width-regions.html fast/regions/percentage-margins-rtl-variable-width-regions.html fast/regions/percentage-margins-mixed-rtl-dominant-regions.html fast/regions/percentage-margins-mixed-ltr-dominant-regions.html Should be ref tests

Attachments
Patch (692.80 KB, patch) 2013-07-22 04:52 PDT, Andrei Bucur	no flags	Details Formatted Diff Diff
Patch (759.17 KB, patch) 2013-07-23 00:51 PDT, Andrei Bucur	no flags	Details Formatted Diff Diff
Patch (760.52 KB, patch) 2013-07-23 08:58 PDT, Andrei Bucur	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Andrei Bucur

Comment 1 2013-07-22 04:52:28 PDT

Created attachment 207239 [details] Patch

WebKit Commit Bot

Comment 2 2013-07-22 07:01:22 PDT

Comment on attachment 207239 [details] Patch Clearing flags on attachment: 207239 Committed r152968: <http://trac.webkit.org/changeset/152968>

WebKit Commit Bot

Comment 3 2013-07-22 07:01:24 PDT

All reviewed patches have been landed. Closing bug.

WebKit Commit Bot

Comment 4 2013-07-22 10:58:30 PDT

Re-opened since this is blocked by bug 118975

Andrei Bucur

Comment 5 2013-07-23 00:51:47 PDT

Created attachment 207308 [details] Patch

Mihnea Ovidenie

Comment 6 2013-07-23 04:12:02 PDT

(In reply to comment #5) > Created an attachment (id=207308) [details] > Patch Looks good. I have 3 comments: -> using Ahem font, makes the test less readable, maybe you should add a description to the tests about the expected behavior? Or a note in changelog about what these tests are intended to check? -> I prefer to use the monospace font instead of Ahem, usually font: 16px/1.25 monospace, but it is just a preference. -> why are you using <span style="line-height: 100px;">XXXXXX</span> in *-expected.html files? Do you need them in all the boxes?

Andrei Bucur

Comment 7 2013-07-23 08:53:53 PDT

(In reply to comment #6) > (In reply to comment #5) > > Created an attachment (id=207308) [details] [details] > > Patch > > Looks good. I have 3 comments: > -> using Ahem font, makes the test less readable, maybe you should add a description to the tests about the expected behavior? Or a note in changelog about what these tests are intended to check? Will do before landing the patch. > -> I prefer to use the monospace font instead of Ahem, usually font: 16px/1.25 monospace, but it is just a preference. I've noticed differences between platforms. It's important to really have the same text in each region as the ref test. > -> why are you using <span style="line-height: 100px;">XXXXXX</span> in *-expected.html files? Do you need them in all the boxes? To push the bottom border further down and then clip it with overflow: hidden. This way the ref test divs look like they are fragmented.

Andrei Bucur

Comment 8 2013-07-23 08:58:50 PDT

Created attachment 207331 [details] Patch

WebKit Commit Bot

Comment 9 2013-07-23 10:35:34 PDT

Comment on attachment 207331 [details] Patch Clearing flags on attachment: 207331 Committed r153057: <http://trac.webkit.org/changeset/153057>

WebKit Commit Bot

Comment 10 2013-07-23 10:35:38 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.