Bug 118718
| Summary: | Don't warn about NULL usage in GTK functions even when a functional call spans multiple lines | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kwang Yul Seo <skyul> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | pnormand |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Kwang Yul Seo
Bug 32858, 39372, 70498, 43090, 51758 and 77890 add exceptions to the null check rule of check-webkit-style so that check-webkit-style won't warn about NULL usage in some GTK functions such as g_*() and gst_().
However, the implementation of the null check in check-webkit-style only matches one line at a time so that it fails to match if a function spans multiple lines. For example, check-webkit-style emits a style error if g_object_set spans multiple lines as in https://bugs.webkit.org/show_bug.cgi?id=118657#c20
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |