Summary: | Bug 11866 caused layout test regression in fast/forms/input-value.html | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Component: | Forms | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ddkilzer, KwhiteRight, mrowe | ||||
Priority: | P2 | Keywords: | LayoutTestFailure | ||||
Version: | 420+ | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2006-12-18 16:36:01 PST
Looks like the expected results just need to be updated. If the goal is to match IE or Gecko, then it should have "after" in the second column for "hidden with value property changed", and this is a regression. If the goal is to make sense, then I'd argue for "before", to match text and password fields. I suppose trying to make sense is a bit quixotic here. The two problems (the layout test failing now, and all three of those input types' attributes not doing what IE does) seem like separate issues to me. What if I change the expected results to show "before" in the second column for hidden fields, just as they do for text and password fields, and then file a new bug to change the behavior of all three types to match what IE does? That sounds fine to me. Created attachment 11912 [details]
Patch with updated results.
Comment on attachment 11912 [details]
Patch with updated results.
Okay!
Landed in r18292. Kirby, can you please file the followup bug? |