Bug 11870

Summary: Bug 11866 caused layout test regression in fast/forms/input-value.html
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, KwhiteRight, mrowe
Priority: P2 Keywords: LayoutTestFailure
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Patch with updated results. beidson: review+

David Kilzer (:ddkilzer)
Reported 2006-12-18 16:36:01 PST
The patch for Bug 11866 caused a layout test regression in fast/forms/input-value.html. http://build.webkit.org/results/post-commit-powerpc-mac-os-x/4737/
Attachments
Patch with updated results. (1.42 KB, patch)
2006-12-18 18:05 PST, Mark Rowe (bdash) 		beidson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2006-12-18 16:37:23 PST
Looks like the expected results just need to be updated.
Kirby White
Comment 2 2006-12-18 16:50:16 PST
If the goal is to match IE or Gecko, then it should have "after" in the second column for "hidden with value property changed", and this is a regression. If the goal is to make sense, then I'd argue for "before", to match text and password fields. I suppose trying to make sense is a bit quixotic here.
Kirby White
Comment 3 2006-12-18 17:30:38 PST
The two problems (the layout test failing now, and all three of those input types' attributes not doing what IE does) seem like separate issues to me. What if I change the expected results to show "before" in the second column for hidden fields, just as they do for text and password fields, and then file a new bug to change the behavior of all three types to match what IE does?
Mark Rowe (bdash)
Comment 4 2006-12-18 17:43:36 PST
That sounds fine to me.
Mark Rowe (bdash)
Comment 5 2006-12-18 18:05:30 PST
Created attachment 11912 [details] Patch with updated results.
Brady Eidson
Comment 6 2006-12-18 18:16:14 PST
Comment on attachment 11912 [details] Patch with updated results. Okay!
Mark Rowe (bdash)
Comment 7 2006-12-18 18:18:29 PST
Landed in r18292. Kirby, can you please file the followup bug?
Kirby White
Comment 8 2006-12-18 18:40:39 PST
Filed as bug 11871.
Note You need to log in before you can comment on or make changes to this bug.