Bug 118699

Summary: [EFL][WK2] Replace mouseClick with more meaningful method in test_ewk2_text_checker.cpp
Product: WebKit Reporter: Donggwan Kim <donggwan.kim>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, gyuyoung.kim, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Bug Depends on:    
Bug Blocks: 118698    
Attachments:
Description Flags
Patch
none
Patch none

Description Donggwan Kim 2013-07-15 18:26:21 PDT
Many mouseClick methods are used in test_ewk2_text_checker.cpp.
But it is difficult to understand what they mean.
So i would like to replace those with more meaningful method for readability.
Comment 1 Donggwan Kim 2013-07-15 23:01:31 PDT
Created attachment 206725 [details]
Patch
Comment 2 Chris Dumez 2013-07-15 23:23:03 PDT
Comment on attachment 206725 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206725&action=review

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:74
> +    void showContextMenuWithFirstLineText()

How about introducing enums:
enum Line { FirstLine, SecondLine }
enum Button { SelectAllWithSpellcheckButton, SelectAllWithoutSpellcheckButton, SelectSubWordWithSpellcheckButton }

and rename the methods to:
clickButton(Button button);
showContextMenu(Line line);
selectFirstWord(Line line);
Comment 3 Donggwan Kim 2013-07-15 23:25:35 PDT
It sounds good to me. 
I will modify and upload the patch again as you guided.
Comment 4 Donggwan Kim 2013-07-15 23:44:34 PDT
Created attachment 206729 [details]
Patch
Comment 5 Donggwan Kim 2013-07-15 23:44:57 PDT
It sounds good to me. 
I will modify and upload the patch again as you guided.
Comment 6 Chris Dumez 2013-07-15 23:56:58 PDT
Comment on attachment 206729 [details]
Patch

Ok, r=me.
Comment 7 WebKit Commit Bot 2013-07-16 00:34:59 PDT
Comment on attachment 206729 [details]
Patch

Clearing flags on attachment: 206729

Committed r152708: <http://trac.webkit.org/changeset/152708>
Comment 8 WebKit Commit Bot 2013-07-16 00:35:01 PDT
All reviewed patches have been landed.  Closing bug.