Summary: | [EFL][WK2] Replace mouseClick with more meaningful method in test_ewk2_text_checker.cpp | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Donggwan Kim <donggwan.kim> | ||||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, commit-queue, gyuyoung.kim, rakuco | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | Linux | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 118698 | ||||||||
Attachments: |
|
Description
Donggwan Kim
2013-07-15 18:26:21 PDT
Created attachment 206725 [details]
Patch
Comment on attachment 206725 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206725&action=review > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:74 > + void showContextMenuWithFirstLineText() How about introducing enums: enum Line { FirstLine, SecondLine } enum Button { SelectAllWithSpellcheckButton, SelectAllWithoutSpellcheckButton, SelectSubWordWithSpellcheckButton } and rename the methods to: clickButton(Button button); showContextMenu(Line line); selectFirstWord(Line line); It sounds good to me. I will modify and upload the patch again as you guided. Created attachment 206729 [details]
Patch
It sounds good to me. I will modify and upload the patch again as you guided. Comment on attachment 206729 [details]
Patch
Ok, r=me.
Comment on attachment 206729 [details] Patch Clearing flags on attachment: 206729 Committed r152708: <http://trac.webkit.org/changeset/152708> All reviewed patches have been landed. Closing bug. |