Bug 118679

Summary: NetworkStorageSession::createDefaultSession is only implemented by Soup
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Page LoadingAssignee: Kwang Yul Seo <skyul>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, danw, gustavo, gyuyoung.kim, kbalazs, mrobinson, rakuco, skyul
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alexey Proskuryakov
Reported 2013-07-15 10:36:08 PDT
NetworkStorageSession::createDefaultSession() is declared a cross-platform function, but it is only implemented or used by Soup. Can you please fix this? I suspect that it is just incorrect, as there is only one default session, which is returned by defaultStorageSession().
Attachments
Patch (4.75 KB, patch)
2013-07-15 16:19 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2013-07-15 15:30:17 PDT
(In reply to comment #0) > NetworkStorageSession::createDefaultSession() is declared a cross-platform function, but it is only implemented or used by Soup. > > Can you please fix this? I suspect that it is just incorrect, as there is only one default session, which is returned by defaultStorageSession(). Currently, only _ewk_view_priv_new in WebKit/efl/ewk/ewk_view.cpp uses this method. This is incorrect because we already have defaultStorageSession(). I will fix it.
Kwang Yul Seo
Comment 2 2013-07-15 16:19:56 PDT
Created attachment 206699 [details] Patch
Kwang Yul Seo
Comment 3 2013-07-15 16:40:45 PDT
Comment on attachment 206699 [details] Patch Clearing flags on attachment: 206699 Committed r152672: <http://trac.webkit.org/changeset/152672>
Kwang Yul Seo
Comment 4 2013-07-15 16:40:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.