Bug 118672

Summary: Introduce toHTMLIFrameElement
Product: WebKit Reporter: Kangil Han <kangil.han>
Component: WebCore Misc.Assignee: Kangil Han <kangil.han>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, commit-queue, esprehn+autocc, glenn, kling, koivisto, macpherson, menard, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Kangil Han
Reported 2013-07-15 05:58:14 PDT
Introduce toHTMLIFrameElement
Attachments
Patch (8.92 KB, patch)
2013-07-15 06:03 PDT, Kangil Han 		no flags
DetailsFormatted DiffDiff
Patch (8.88 KB, patch)
2013-07-15 17:51 PDT, Kangil Han 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kangil Han
Comment 1 2013-07-15 06:03:50 PDT
Created attachment 206659 [details] Patch
Ryosuke Niwa
Comment 2 2013-07-15 11:16:35 PDT
Comment on attachment 206659 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206659&action=review > Source/WebCore/dom/Document.cpp:5640 > + return toHTMLIFrameElement(this->ownerElement()); It seems like we don't need "this->" anymore.
Kangil Han
Comment 3 2013-07-15 17:51:16 PDT
Created attachment 206708 [details] Patch
Kangil Han
Comment 4 2013-07-15 21:19:10 PDT
(In reply to comment #2) > (From update of attachment 206659 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=206659&action=review > > > Source/WebCore/dom/Document.cpp:5640 > > + return toHTMLIFrameElement(this->ownerElement()); > > It seems like we don't need "this->" anymore. Done, thx Ryosuke! :)
WebKit Commit Bot
Comment 5 2013-07-15 22:00:29 PDT
Comment on attachment 206708 [details] Patch Clearing flags on attachment: 206708 Committed r152704: <http://trac.webkit.org/changeset/152704>
WebKit Commit Bot
Comment 6 2013-07-15 22:00:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.