Bug 118653

Summary: Add toSVGFilterElement() and use it
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: SVGAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, dino, d-r, esprehn+autocc, fmalita, glenn, pdr, rniwa, schenney, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion
none
Patch for landing none

Description Gyuyoung Kim 2013-07-14 01:03:54 PDT
We can use toSVGFilterElement() instead of using static_cast<..> to improve readability. Beside blink also uses it.
Comment 1 Gyuyoung Kim 2013-07-14 01:07:42 PDT
Created attachment 206628 [details]
Patch
Comment 2 Build Bot 2013-07-14 03:14:30 PDT
Comment on attachment 206628 [details]
Patch

Attachment 206628 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1063594

New failing tests:
fullscreen/full-screen-iframe-with-max-width-height.html
Comment 3 Build Bot 2013-07-14 03:14:33 PDT
Created attachment 206629 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.3
Comment 4 Gyuyoung Kim 2013-07-14 05:18:38 PDT
Created attachment 206631 [details]
Patch for landing
Comment 5 Gyuyoung Kim 2013-07-14 05:19:40 PDT
(In reply to comment #2)
> (From update of attachment 206628 [details])
> Attachment 206628 [details] did not pass mac-ews (mac):
> Output: http://webkit-queues.appspot.com/results/1063594
> 
> New failing tests:
> fullscreen/full-screen-iframe-with-max-width-height.html

Looks unrelated to this patch.
Comment 6 WebKit Commit Bot 2013-07-14 06:59:53 PDT
Comment on attachment 206631 [details]
Patch for landing

Clearing flags on attachment: 206631

Committed r152615: <http://trac.webkit.org/changeset/152615>
Comment 7 WebKit Commit Bot 2013-07-14 06:59:56 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Csaba Osztrogon√°c 2013-07-14 10:39:49 PDT
Comment on attachment 206631 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=206631&action=review

> Source/WebCore/svg/SVGFilterElement.h:80
> +    ASSERT_WITH_SECURITY_IMPLICATION(!node || node->hasTagName(SVGNames::filterTag));

It broke the debug builds. Could you fix it please?
(Otherwise it would be great if you could try a debug build locally 
next time if you add an assertion, because assertions are debug only.)
Comment 9 Ryosuke Niwa 2013-07-14 18:17:39 PDT
Fixed builds in http://trac.webkit.org/changeset/152619.
Comment 10 Gyuyoung Kim 2013-07-14 18:44:23 PDT
(In reply to comment #8)
> (From update of attachment 206631 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206631&action=review
> 
> > Source/WebCore/svg/SVGFilterElement.h:80
> > +    ASSERT_WITH_SECURITY_IMPLICATION(!node || node->hasTagName(SVGNames::filterTag));
> 
> It broke the debug builds. Could you fix it please?
> (Otherwise it would be great if you could try a debug build locally 
> next time if you add an assertion, because assertions are debug only.)

I too often forget to check if debug build is fine. :( Sorry about that. I will check debug build in next time.
Comment 11 Gyuyoung Kim 2013-07-14 18:44:36 PDT
(In reply to comment #8)
> (From update of attachment 206631 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206631&action=review
> 
> > Source/WebCore/svg/SVGFilterElement.h:80
> > +    ASSERT_WITH_SECURITY_IMPLICATION(!node || node->hasTagName(SVGNames::filterTag));
> 
> It broke the debug builds. Could you fix it please?
> (Otherwise it would be great if you could try a debug build locally 
> next time if you add an assertion, because assertions are debug only.)

I too often forget to check if debug build is fine. :( Sorry about that. I will check debug build in next time.