Summary: | Add toSVGFilterElement() and use it | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||||
Component: | SVG | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, dino, d-r, esprehn+autocc, fmalita, glenn, pdr, rniwa, schenney, zimmermann | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Gyuyoung Kim
2013-07-14 01:03:54 PDT
Created attachment 206628 [details]
Patch
Comment on attachment 206628 [details] Patch Attachment 206628 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1063594 New failing tests: fullscreen/full-screen-iframe-with-max-width-height.html Created attachment 206629 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.3
Created attachment 206631 [details]
Patch for landing
(In reply to comment #2) > (From update of attachment 206628 [details]) > Attachment 206628 [details] did not pass mac-ews (mac): > Output: http://webkit-queues.appspot.com/results/1063594 > > New failing tests: > fullscreen/full-screen-iframe-with-max-width-height.html Looks unrelated to this patch. Comment on attachment 206631 [details] Patch for landing Clearing flags on attachment: 206631 Committed r152615: <http://trac.webkit.org/changeset/152615> All reviewed patches have been landed. Closing bug. Comment on attachment 206631 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=206631&action=review > Source/WebCore/svg/SVGFilterElement.h:80 > + ASSERT_WITH_SECURITY_IMPLICATION(!node || node->hasTagName(SVGNames::filterTag)); It broke the debug builds. Could you fix it please? (Otherwise it would be great if you could try a debug build locally next time if you add an assertion, because assertions are debug only.) Fixed builds in http://trac.webkit.org/changeset/152619. (In reply to comment #8) > (From update of attachment 206631 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=206631&action=review > > > Source/WebCore/svg/SVGFilterElement.h:80 > > + ASSERT_WITH_SECURITY_IMPLICATION(!node || node->hasTagName(SVGNames::filterTag)); > > It broke the debug builds. Could you fix it please? > (Otherwise it would be great if you could try a debug build locally > next time if you add an assertion, because assertions are debug only.) I too often forget to check if debug build is fine. :( Sorry about that. I will check debug build in next time. (In reply to comment #8) > (From update of attachment 206631 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=206631&action=review > > > Source/WebCore/svg/SVGFilterElement.h:80 > > + ASSERT_WITH_SECURITY_IMPLICATION(!node || node->hasTagName(SVGNames::filterTag)); > > It broke the debug builds. Could you fix it please? > (Otherwise it would be great if you could try a debug build locally > next time if you add an assertion, because assertions are debug only.) I too often forget to check if debug build is fine. :( Sorry about that. I will check debug build in next time. |