Bug 118626
| Summary: | Introduce non-virtual Node::isFocusable and virtual rendererIsFocusable | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Forms | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | jonlee, kling, koivisto, tkent |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Consider merging https://chromium.googlesource.com/chromium/blink/+/94f9474455c2f83c606293c2608c0db8d266ada6
Before this patch, there were two virtual methods Node::isFocusable and
Node::supportsFocus. This patch renames isFocusable to rendererIsFocusable, and
introduces a new non-virtual method isFocusable which calls supportsFocus and
rendererIsFocusable.
The motivation is to clarify the purposes of the two virtual methods and
provide a central place for universal checks on focusability, such as whether
the node is in the document and non-inert (to be added later).
This patch is just a refactoring and should not change behavior.
Also see https://chromium.googlesource.com/chromium/blink/+/a21759964af400159c6ef86c57a7b677202bbffa
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
There has been a number of patches dependent on this one including https://chromium.googlesource.com/chromium/blink/+/a85c013184cf9e663f8bb74abbecfefc924807c0%5E%21/#F0
Ryosuke Niwa
We're not gonna do merge this at this point.