Bug 118619
| Summary: | Simplify LocalStorage and SessionStorage to reduce the size of PageGroup | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | andersca, mark.lam, msaboff, sam |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Consider merging https://chromium.googlesource.com/chromium/blink/+/2b5b2e5c7a3c26e7f0b17c48137d17f140528b0d
Quite a few cleanups in one:
- Expose only a StorageArea factory for LocalStorage to core.
- With the above, only use StorageNamespace instances to manage SessionStorage.
- Eliminate all the unused methods of StorageNamepace from Blink, especially
copy() (the last user was DumpRenderTree, which is now gone). Copying session
storage on window creation is handled on the Chromium side.
- Use OwnPtrs instead of RefPtrs for managing the lifetime of
StorageNamespace and StorageArea.
This change also has the advantage of further-reducing the size of PageGroup.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Anders Carlsson
I don’t know if this patch would even apply cleanly - I’ve done a lot of cleanup in the storage code to make it better.
Ryosuke Niwa
Should we close this as WONTFIX then?
Sam Weinig
Yes.