Bug 118618
Summary: | Don't force layout for offsetWidth of fixed width elements | ||
---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED WONTFIX | ||
Severity: | Normal | CC: | benjamin, dino, hyatt, karlcow, simon.fraser |
Priority: | P2 | Keywords: | BlinkMergeCandidate |
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Bug Depends on: | 118930 | ||
Bug Blocks: |
Ryosuke Niwa
Consider merging https://chromium.googlesource.com/chromium/blink/+/5117d5329f6cdf071dfec25d9026a105070142b6
This improves page load time of The Economist by 41% (3.4s -> 2.0s) on
my z620 workstation.
I believe the change in the inspector/styles/device-metrics-fit-window.html expectations is a progression.
The div being measured has a fixed width of 1024 and there is a zoom on the page.
It looks to me like there was a rounding error previously.
Also see the bug 118032
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Simon Fraser (smfr)
Nice. I don't like the "fixed" terminology though; too easily confused with fixed position.
Ryosuke Niwa
Also see https://chromium.googlesource.com/chromium/blink/+/ff234b1593b2b493d47f38f687d09a87bc42c9eb.
Ryosuke Niwa
Also see the bug 118032.
Ryosuke Niwa
Also merge:
https://src.chromium.org/viewvc/blink?revision=154203&view=revision
https://src.chromium.org/viewvc/blink?revision=154292&view=revision
Ryosuke Niwa
Also see https://chromium.googlesource.com/chromium/blink/+/58a5fac292a5b3f79b00cdc71074fbf8be2ebc2b
Ryosuke Niwa
The optimization removed in https://chromium.googlesource.com/chromium/blink/+/e6648e2c65b3472faf5025cb19029afe71b7a7f0
Karl Dubost
This is probably not relevant anymore.