Bug 118605

Summary: Web Inspector: update CodeMirror to 3.14.1
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, thorton, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 118658    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Timothy Hatcher
Reported 2013-07-12 07:57:18 PDT
There are a few fixes in 7f560afa1c that fix regressions from CodeMirror 3.14 that we should pick up and live on.
Attachments
Patch (231.61 KB, patch)
2013-07-12 07:59 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (237.74 KB, patch)
2013-07-15 15:35 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-07-12 07:57:37 PDT
<rdar://problem/14427280>
Timothy Hatcher
Comment 2 2013-07-12 07:59:39 PDT
Created attachment 206548 [details] Patch
Sam Weinig
Comment 3 2013-07-12 11:09:26 PDT
Comment on attachment 206548 [details] Patch rs=me
WebKit Commit Bot
Comment 4 2013-07-12 11:32:24 PDT
Comment on attachment 206548 [details] Patch Clearing flags on attachment: 206548 Committed r152598: <http://trac.webkit.org/changeset/152598>
WebKit Commit Bot
Comment 5 2013-07-12 11:32:26 PDT
All reviewed patches have been landed. Closing bug.
Tim Horton
Comment 6 2013-07-14 23:37:00 PDT
This totally broke the inspector for me. CodeMirror.js:701: JS ERROR: SyntaxError: Expected token '}' I'm going to roll it out.
WebKit Commit Bot
Comment 7 2013-07-14 23:38:19 PDT
Re-opened since this is blocked by bug 118658
Timothy Hatcher
Comment 8 2013-07-15 08:00:54 PDT
This happened because the JS minifier caused an error in CodeMirror. We fixed this before, but I forgot to upstream that fix to CodeMirror.
Timothy Hatcher
Comment 9 2013-07-15 15:35:46 PDT
Created attachment 206694 [details] Patch
Joseph Pecoraro
Comment 10 2013-07-15 15:38:05 PDT
Comment on attachment 206694 [details] Patch r=me
WebKit Commit Bot
Comment 11 2013-07-15 16:30:36 PDT
Comment on attachment 206694 [details] Patch Clearing flags on attachment: 206694 Committed r152669: <http://trac.webkit.org/changeset/152669>
WebKit Commit Bot
Comment 12 2013-07-15 16:30:38 PDT
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 13 2013-08-23 13:31:29 PDT
Oops, I did this again…
Note You need to log in before you can comment on or make changes to this bug.