Bug 118583 – [EFL] Add fallback for TestWebKitAPI if opengl is not available.

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Donggwan Kim]

Ewk2 API tests fail if ecore_evas_new() fails return Ecore_Evas* from initEcoreEvas() in Tools/TestWebKitAPI/efl/PlatformWebView.cpp.

Here's the logs when ecore_evas_new() is failed.
ERR<28903>:ecore_evas ecore_evas_x.c:254 _ecore_evas_x_gl_window_new() evas_engine_info_set() for engine 'opengl_x11' failed.

It's a same solution with https://bugs.webkit.org/show_bug.cgi?id=102704 and https://bugs.webkit.org/show_bug.cgi?id=117504

[Donggwan Kim]

Created attachment 206506 [details]
Patch

[Chris Dumez]

Comment on attachment 206506 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206506&action=review

> Tools/TestWebKitAPI/efl/PlatformWebView.cpp:48
> +    Ecore_Evas* ecoreEvas = 0;

initialization does not seem needed.

> Tools/TestWebKitAPI/efl/PlatformWebView.cpp:50
> +    const char* engine = "opengl_x11";

This variable is not needed. please pass "opengl_x11" directly to ecore_evas_new().

> Tools/TestWebKitAPI/efl/PlatformWebView.cpp:-54
> -    ASSERT(ecoreEvas);

Why remove the assertion?

[Donggwan Kim]

Created attachment 206637 [details]
Patch

[Donggwan Kim]

Comment on attachment 206506 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206506&action=review

>> Tools/TestWebKitAPI/efl/PlatformWebView.cpp:48
>> +    Ecore_Evas* ecoreEvas = 0;
> 
> initialization does not seem needed.

Done.

>> Tools/TestWebKitAPI/efl/PlatformWebView.cpp:50
>> +    const char* engine = "opengl_x11";
> 
> This variable is not needed. please pass "opengl_x11" directly to ecore_evas_new().

Done.

>> Tools/TestWebKitAPI/efl/PlatformWebView.cpp:-54
>> -    ASSERT(ecoreEvas);
> 
> Why remove the assertion?

You are right. I appended the assertion again.

[Gyuyoung Kim]

Comment on attachment 206637 [details]
Patch

LGTM. I think chris is going to review. ;-)

[Build Bot]

Comment on attachment 206637 [details]
Patch

Attachment 206637 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1070467

New failing tests:
http/tests/security/cross-origin-plugin-private-browsing-toggled.html

[Build Bot]

Created attachment 206638 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3

[Chris Dumez]

Comment on attachment 206637 [details]
Patch

Looks fine, r=me.

[Donggwan Kim]

It doesn't seem to be related to this patch.
So i cleared commit-queue.

[Ryuan Choi]

Comment on attachment 206637 [details]
Patch

Let's try once more.

cq+ed

[WebKit Commit Bot]

Comment on attachment 206637 [details]
Patch

Clearing flags on attachment: 206637

Committed r152675: <http://trac.webkit.org/changeset/152675>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.