Bug 118525

Summary: Get rid of SVGPathSeg* special casing in the bindings generator
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, d-r, fmalita, haraken, krit, laszlo.gombos, pdr, rniwa, rwlbuis, schenney
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP Patch
none
Patch
haraken: review+
Patch for landing none

Chris Dumez
Reported 2013-07-10 00:42:45 PDT
Have one header per SVGPathSeg* type so that we no longer need special casing in the bindings generator.
Attachments
WIP Patch (70.37 KB, patch)
2013-07-10 01:02 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (101.15 KB, patch)
2013-07-10 02:39 PDT, Chris Dumez 		haraken: review+
DetailsFormatted DiffDiff
Patch for landing (98.56 KB, patch)
2013-07-11 01:23 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-07-10 01:02:20 PDT
Created attachment 206372 [details] WIP Patch
Chris Dumez
Comment 2 2013-07-10 02:39:03 PDT
Created attachment 206374 [details] Patch
Mikhail Pozdnyakov
Comment 3 2013-07-10 03:42:59 PDT
Comment on attachment 206374 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206374&action=review > Source/WebCore/svg/SVGPathSegArcRel.h:44 > + virtual String pathSegTypeAsLetter() const { return "a"; } It looks that ASCIILiteral would be nice to have here.
Chris Dumez
Comment 4 2013-07-10 03:55:55 PDT
(In reply to comment #3) > (From update of attachment 206374 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=206374&action=review > > > Source/WebCore/svg/SVGPathSegArcRel.h:44 > > + virtual String pathSegTypeAsLetter() const { return "a"; } > > It looks that ASCIILiteral would be nice to have here. I am not sure we want to do such changes in this patch. This patch is really about splitting the code so that we can get rid of special cases in the bindings generator. I don't mind making such changes if people think it is a good idea though.
Chris Dumez
Comment 5 2013-07-11 00:58:05 PDT
@haraken: Is this something you could review? The important changes are to the bindings generator, the SVG code is merely split into separate files without any change.
Kentaro Hara
Comment 6 2013-07-11 01:15:12 PDT
Comment on attachment 206374 [details] Patch The code generator change looks good. Other changes are just moving code. Looks OK.
Chris Dumez
Comment 7 2013-07-11 01:23:26 PDT
Created attachment 206435 [details] Patch for landing
WebKit Commit Bot
Comment 8 2013-07-11 04:20:16 PDT
Comment on attachment 206435 [details] Patch for landing Clearing flags on attachment: 206435 Committed r152565: <http://trac.webkit.org/changeset/152565>
WebKit Commit Bot
Comment 9 2013-07-11 04:20:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.