Bug 118521

Summary: [EFL] Add ewk_view_device_pixel_ratio_set
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, gyuyoung.kim, kangil.han, lucas.de.marchi, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ryuan Choi
Reported 2013-07-09 19:04:15 PDT
Now, ewebkit and ewebkit2 have different approach about getting device pixel ratio. ewebkit depends on deprecatedTargetDPI and ecore_x_dpi_get but ewebkit2 use Page::deviceScaleFactor.
Attachments
Patch (13.86 KB, patch)
2013-07-09 19:36 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2013-07-09 19:36:17 PDT
Created attachment 206361 [details] Patch
Gyuyoung Kim
Comment 2 2013-07-09 20:06:25 PDT
Comment on attachment 206361 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206361&action=review Looks OK. > Tools/EWebLauncher/main.c:153 > + double device_pixel_ratio; Isn't float more clear ?
Ryuan Choi
Comment 3 2013-07-09 20:33:55 PDT
Committed r152523: <http://trac.webkit.org/changeset/152523>
Ryuan Choi
Comment 4 2013-07-09 20:34:36 PDT
(In reply to comment #2) > (From update of attachment 206361 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=206361&action=review > > Looks OK. > > > Tools/EWebLauncher/main.c:153 > > + double device_pixel_ratio; > > Isn't float more clear ? Landed after fixed like you mentioned. Thank you
Note You need to log in before you can comment on or make changes to this bug.