| Summary: | [GTK] WebKitTestRunner tries to remove an already deleted event in EventSenderProxy::replaySavedEvents | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Pena <spenap> | ||||
| Component: | New Bugs | Assignee: | Simon Pena <spenap> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cgarcia, commit-queue, haraken, kenneth, mrobinson, simon.fraser | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Pena
2013-07-09 09:08:57 PDT
Created attachment 206327 [details]
Patch
Comment on attachment 206327 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206327&action=review > Tools/ChangeLog:14 > + fast/events/mousedown-inside-dragstart-should-not-cause-crash.html no longer > + crashes after this fix is added. This patch isn't removing it from the TestExpectations file though? (In reply to comment #2) > This patch isn't removing it from the TestExpectations file though? No, it isn't. The GTK-WK2 buildbot is a bit red these days, and this test has been failing probably forever (the flakiness dashboard doesn't have any records of it passing). I am (slowly) trying to improve the bots situation these days, maybe I should have started skipping them first, and then go on with fixes? (In reply to comment #3) > (In reply to comment #2) > > This patch isn't removing it from the TestExpectations file though? > > No, it isn't. The GTK-WK2 buildbot is a bit red these days, and this test has been failing probably forever (the flakiness dashboard doesn't have any records of it passing). (The test wasn't skipped on GTK-WK1, it worked fine there) Comment on attachment 206327 [details]
Patch
It's fine to just fix it now. Thanks!
Comment on attachment 206327 [details] Patch Clearing flags on attachment: 206327 Committed r152530: <http://trac.webkit.org/changeset/152530> All reviewed patches have been landed. Closing bug. |