Bug 118496

Summary:

Use toSVGFontElement() instead of static_cast<SVGFontElement*>

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

SVG

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, d-r, fmalita, pdr, schenney, zimmermann

Priority:

Keywords:

BlinkMergeCandidate

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Gyuyoung Kim

Reported 2013-07-09 01:46:02 PDT

As a step to change static_cast with toXXX, static_cast<SVGFontElement*> can be changed with toSVGFontElement(). Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=153761

Attachments
Patch (6.47 KB, patch) 2013-07-09 01:51 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Gyuyoung Kim

Comment 1 2013-07-09 01:51:10 PDT

Created attachment 206300 [details] Patch

Andreas Kling

Comment 2 2013-07-09 04:09:14 PDT

Comment on attachment 206300 [details] Patch r=me. It would be nice to have an isSVGFontElement(const Node*) instead of checking hasTagName().

Gyuyoung Kim

Comment 3 2013-07-09 04:10:36 PDT

(In reply to comment #2) > (From update of attachment 206300 [details]) > r=me. > > It would be nice to have an isSVGFontElement(const Node*) instead of checking hasTagName(). Ok, no problem. I will file a bug for it.

WebKit Commit Bot

Comment 4 2013-07-09 04:32:07 PDT

Comment on attachment 206300 [details] Patch Clearing flags on attachment: 206300 Committed r152491: <http://trac.webkit.org/changeset/152491>

WebKit Commit Bot

Comment 5 2013-07-09 04:32:10 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.