| Summary: | Workaround for x86 optimizer bug in MSVC 2012. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Brüning <michael.bruning> | ||||||||
| Component: | New Bugs | Assignee: | Michael Brüning <michael.bruning> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | benjamin, buildbot, cmarcelo, commit-queue, hausmann, jturcotte, rniwa | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Michael Brüning
2013-07-08 11:53:10 PDT
Created attachment 206262 [details]
Patch
Comment on attachment 206262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206262&action=review > Source/WTF/wtf/text/StringImpl.cpp:488 > +#if PLATFORM(QT) && CPU(X86) && defined(_MSC_VER) && _MSC_VER >=1700 Why PLATFORM(QT)? (In reply to comment #2) > (From update of attachment 206262 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=206262&action=review > > > Source/WTF/wtf/text/StringImpl.cpp:488 > > +#if PLATFORM(QT) && CPU(X86) && defined(_MSC_VER) && _MSC_VER >=1700 > > Why PLATFORM(QT)? Just because it was only reported with Qt so far - but you're right, it shouldn't hurt to put it in for other platforms using MSVC 2012 on x86 as well. Created attachment 206301 [details]
Patch
Comment on attachment 206301 [details] Patch Attachment 206301 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/911531 New failing tests: fullscreen/full-screen-iframe-with-max-width-height.html Created attachment 206313 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3
(In reply to comment #6) > Created an attachment (id=206313) [details] > Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 > > The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. > Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3 Hm, I wonder how a change flagged for Visual Studio only would cause failures on the Mac port - is the tree on the ews in a bad state maybe? Comment on attachment 206301 [details]
Patch
You can double check but I think the bot is just sick.
OS X is 64bits, and does not use MSVC :)
Committed r152529: <http://trac.webkit.org/changeset/152529> |